Fix IncrementalDelaunayTriangulator to ensure triangulation boundary is convex #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaston
reviewed
Sep 6, 2023
|
Thanks. |
mwtoews
pushed a commit
to mwtoews/geos
that referenced
this pull request
Jan 26, 2024
mwtoews
added a commit
that referenced
this pull request
Jan 31, 2024
* Fix IncrementalDelaunayTriangulator to ensure triangulation boundary is convex (#953) * Fix compile errors * Add to NEWS.md --------- Co-authored-by: Martin Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of locationtech/jts#1004
This adds logic to
IncrementalDelaunayTriangulatorto ensure that the triangulation boundary is always convex (as per specification). This is required because the "frame" created to contain the triangulation construction is not infinitely distant from the input points. This has been causing robustness failures in cases where a site lies very close to the convex hull of the input.This is a robust enhancement that replaces the frame size heuristic change in #728.
Also fixes issues reported for
ConcaveHull( #719, #946)