Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrow C strings instead of copying them #335

Merged
merged 7 commits into from
Feb 4, 2014
Merged

Borrow C strings instead of copying them #335

merged 7 commits into from
Feb 4, 2014

Commits on Feb 4, 2014

  1. utils: allow borrowing a C string 

    We don't always need our own copy of a C string; sometimes we just need
to parse it. Create py_str_borrow_c_str() which returns a char pointer
to python's internal value string, with which we can avoid an extra copy.
    @carlosmn
    carlosmn committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    74d091d View commit details
    Browse the repository at this point in the history

  2. config: borrow the string for lookup and setting 

    We don't need our own copy of the string, so use the new borrowing
mechanism to use python's underlying string for the key to get/set.
    @carlosmn
    carlosmn committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    1c74676 View commit details
    Browse the repository at this point in the history

  3. repository: borrow C strings where possible

    @carlosmn
    carlosmn committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    b4827ba View commit details
    Browse the repository at this point in the history

  4. signature: borrow the name's C string

    @carlosmn
    carlosmn committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    c8a4027 View commit details
    Browse the repository at this point in the history

  5. refspec: borrow the C string

    @carlosmn
    carlosmn committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    6597495 View commit details
    Browse the repository at this point in the history

  6. remote: borrow the C string where possible

    @carlosmn
    carlosmn committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    824ac67 View commit details
    Browse the repository at this point in the history

  7. index entry: avoid extra copy

    @carlosmn
    carlosmn committed Feb 4, 2014
    Configuration menu
    Copy the full SHA
    dcd5acc View commit details
    Browse the repository at this point in the history