Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this PR is a little less straight forward than #772
I think the user should be able to create a Diff object from a unified diff without needing a repository, as in
git_diff_from_buffer
. The existing pygit2 API, however, requires that a Repository be provided when creating a Diff object.This PR relaxes that requirement and allows
NULL
to be provided for the Repository when creating a Diff object. This allows Diffs to be created without repos.If this is a good idea, let's merge this in! If not, let's have a discussion. I'm also open to the idea of having an optional kwarg
repository=
so that we can reuse this code inRepository.parse_diff