-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[META] General structure, flow, & content enhancements #186
Conversation
✅ Deploy Preview for libp2p-docs-mirror ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Create Guides section
It would probably make sense to interchange WebTransprot and WebRTC: Haven't looked at the rest of the structure yet, will do when this is not a draft any more. |
Tagged the team for their input when they have the chance for an initial review |
There's a lot of changed files in this PR, not sure what exactly to review here. The proposed structure from the PR description? |
…ation, re-add reference
@p-shahi @marten-seemann thanks again! Based on the feedback, I decided it's best to simplify the restructure approach here and work off of the current "portal" we have, where we can soon decide on how we'd like to "generally revamp" the libp2p site, docs, etc - I feel there is consensus to do so. We're preparing a proposal on different approaches we can take that I'll share next week. For now, here are highlights of the recent changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the feedback, I decided it's best to simplify the restructure approach here and work off of the current "portal" we have, where we can soon decide on how we'd like to "generally revamp" the libp2p site, docs, etc - I feel there is consensus to do so. We're preparing a proposal on different approaches we can take that I'll share next week.
Ok sounds good.
The changes categorize concepts based on components (but without chapter numbers) and create directories (or sections).
I do like book/chapter style organization. I found that Aleo organizes their docs similarly: https://developer.aleo.org/overview (without numbering.)
Uses index files to capture the overview/summary of the component, then lists a ToC for the specific components related to the general component on the index file (e.g. with Transports - there is a doc for dialing & listening, then for QUIC and WebTransport).
The categories with only "one main overview", are not a directories and are displayed as they originally were.
👍
Reference section added back.
Would note @p-shahi that I had added a redirect when we moved DoS to "Core Components", so if we'd like to reconsider the visibility again, we can do it in this PR.
Yes, let's promote DoS to be under Core Components in this PR.
I meant that we should also keep a DoS page (with a link to Core Components>DoS) under Reference only if there was no redirect. Since you had added a redirect, it can be removed from under Reference. Sorry if there was confusion from my end.
Descriptions updated for all page. but they are not thought-through. This is something I'll update once we decide on the structure as it would be worth having a similar tone and follow a standard on how we refer to different parts of the docs (i.e. sections vs. categories. vs. directories vs. something else.)
👍
@p-shahi gotcha, now back under core components:) |
@marten-seemann these changes should make things more straight forward and great if you can provide a final review. |
Upon merging this, I'll open PRs for AutoNAT, Noise, TLS, and will update yamux, mplex. Regarding QUIC: |
If no qualms, let's merge this by tomorrow e.o.d.
makes sense to me. |
checking here @marten-seemann for any qualms. |
🛳️? |
🚢 it 🚀 |
Context
Original proposed structure with chapter/book approach:
Current restructure: latest preview
Please view the latest Fleek preview here.