fix staticcheck

go.mod

@@ -9,7 +9,6 @@ require (
 	github.com/libp2p/go-libp2p-asn-util v0.0.0-20210211060025-0db24c10d3bd
 	github.com/libp2p/go-libp2p-blankhost v0.2.0
 	github.com/libp2p/go-libp2p-core v0.8.3
-	github.com/libp2p/go-libp2p-metrics v0.1.0
 	github.com/libp2p/go-libp2p-peerstore v0.2.6
 	github.com/libp2p/go-libp2p-swarm v0.4.3
 	github.com/libp2p/go-libp2p-transport-upgrader v0.4.2

go.sum

@@ -203,8 +203,6 @@ github.com/libp2p/go-libp2p-core v0.8.3 h1:BZTReEF6o8g/n4DwxTyeFannOeae35Xy0TD+m
 github.com/libp2p/go-libp2p-core v0.8.3/go.mod h1:FfewUH/YpvWbEB+ZY9AQRQ4TAD8sJBt/G1rVvhz5XT8=
 github.com/libp2p/go-libp2p-loggables v0.1.0 h1:h3w8QFfCt2UJl/0/NW4K829HX/0S4KD31PQ7m8UXXO8=
 github.com/libp2p/go-libp2p-loggables v0.1.0/go.mod h1:EyumB2Y6PrYjr55Q3/tiJ/o3xoDasoRYM7nOzEpoa90=
-github.com/libp2p/go-libp2p-metrics v0.1.0 h1:v7YMUTHNobFaQeqaMfJJMbnK3EPlZeb6/KFm4gE9dks=
-github.com/libp2p/go-libp2p-metrics v0.1.0/go.mod h1:rpoJmXWFxnj7qs5sJ02sxSzrhaZvpqBn8GCG6Sx6E1k=
 github.com/libp2p/go-libp2p-mplex v0.2.1/go.mod h1:SC99Rxs8Vuzrf/6WhmH41kNn13TiYdAWNYHrwImKLnE=
 github.com/libp2p/go-libp2p-mplex v0.2.3/go.mod h1:CK3p2+9qH9x+7ER/gWWDYJ3QW5ZxWDkm+dVvjfuG3ek=
 github.com/libp2p/go-libp2p-mplex v0.4.1 h1:/pyhkP1nLwjG3OM+VuaNJkQT/Pqq73WzB3aDN3Fx1sc=
@@ -452,7 +450,6 @@ golang.org/x/crypto v0.0.0-20181030102418-4d3f4d9ffa16/go.mod h1:6SG95UA2DQfeDnf
 golang.org/x/crypto v0.0.0-20181203042331-505ab145d0a9/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
 golang.org/x/crypto v0.0.0-20190211182817-74369b46fc67/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
 golang.org/x/crypto v0.0.0-20190225124518-7f87c0fbb88b/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
-golang.org/x/crypto v0.0.0-20190228161510-8dd112bcdc25/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20190313024323-a1f597ede03a/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20190426145343-a29dc8fdc734/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=

v2/proto/voucher_test.go

@@ -46,7 +46,7 @@ func TestReservationVoucher(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	envelope, rec, err := record.ConsumeEnvelope(blob, RecordDomain)
+	_, rec, err := record.ConsumeEnvelope(blob, RecordDomain)
 	if err != nil {
 		t.Fatal(err)
 	}

v2/test/compat_test.go

@@ -86,6 +86,9 @@ func TestRelayCompatV2DialV1(t *testing.T) {
 
 	msg := []byte("relay works!")
 	nwritten, err := s.Write(msg)
+	if err != nil {
+		t.Fatal(err)
+	}
 	if nwritten != len(msg) {
 		t.Fatalf("expected to write %d bytes, but wrote %d instead", len(msg), nwritten)
 	}
@@ -159,6 +162,9 @@ func TestRelayCompatV1DialV2(t *testing.T) {
 
 	msg := []byte("relay works!")
 	nwritten, err := s.Write(msg)
+	if err != nil {
+		t.Fatal(err)
+	}
 	if nwritten != len(msg) {
 		t.Fatalf("expected to write %d bytes, but wrote %d instead", len(msg), nwritten)
 	}

v2/test/e2e_test.go

@@ -20,7 +20,7 @@ import (
 
 	logging "github.com/ipfs/go-log"
 	bhost "github.com/libp2p/go-libp2p-blankhost"
-	metrics "github.com/libp2p/go-libp2p-metrics"
+	metrics "github.com/libp2p/go-libp2p-core/metrics"
 	pstoremem "github.com/libp2p/go-libp2p-peerstore/pstoremem"
 	swarm "github.com/libp2p/go-libp2p-swarm"
 	swarmt "github.com/libp2p/go-libp2p-swarm/testing"
@@ -165,6 +165,9 @@ func TestBasicRelay(t *testing.T) {
 
 	msg := []byte("relay works!")
 	nwritten, err := s.Write(msg)
+	if err != nil {
+		t.Fatal(err)
+	}
 	if nwritten != len(msg) {
 		t.Fatalf("expected to write %d bytes, but wrote %d instead", len(msg), nwritten)
 	}

v2/util/io.go

@@ -50,7 +50,7 @@ func (d *DelimitedReader) ReadMsg(msg proto.Message) error {
 	}
 
 	if uint64(len(d.buf)) < mlen {
-		return errors.New("Message too large")
+		return errors.New("message too large")
 	}
 
 	buf := d.buf[:mlen]