skip disconnect events if the message sender does not need them

libp2p · May 12, 2021 · 57eeffe · 57eeffe
1 parent c22b4bf
commit 57eeffe
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/subscriber_notifee.go b/subscriber_notifee.go
@@ -161,6 +161,12 @@ type disconnector interface {
 
 func (nn *subscriberNotifee) Disconnected(n network.Network, v network.Conn) {
 	dht := nn.dht
+
+	ms, ok := dht.msgSender.(disconnector)
+	if !ok {
+		return
+	}
+
 	select {
 	case <-dht.Process().Closing():
 		return
@@ -178,9 +184,7 @@ func (nn *subscriberNotifee) Disconnected(n network.Network, v network.Conn) {
 		return
 	}
 
-	if ms, ok := dht.msgSender.(disconnector); ok {
-		ms.OnDisconnect(dht.Context(), p)
-	}
+	ms.OnDisconnect(dht.Context(), p)
 }
 
 func (nn *subscriberNotifee) Connected(network.Network, network.Conn)      {}