P7: Behaviour pattern penalties #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusefnapora
approved these changes
May 4, 2020
vyzo
force-pushed
the
feat/behavioural-penalties
branch
from
98d2fd9 to
19d0e0f
Compare
|
Rebased on master for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new score parameter, P7, which is a quadratic counter of behavioural pattern penalties.
In contrast to other parameters, which are implicitly updated through tracing, this counter is explicitly incremented by the router.
It is intended to capture and penalize behavioural patterns in #285 and #286, such as not following up on
IWANTrequests fromIHAVEadvertisements or not respecting the prune backoff, but it can also be used for other behaviours in the future.cc @raulk