Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probabilistically track in-flight IWANT requests and apply penalty for broken promises #324

Merged
merged 6 commits into from
May 8, 2020
Merged

Probabilistically track in-flight IWANT requests and apply penalty for broken promises #324

merged 6 commits into from
May 8, 2020

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented May 7, 2020 •
edited
Loading

Closes #285

cc @raulk @daviddias

@vyzo vyzo requested a review from yusefnapora May 7, 2020 19:15
@vyzo
Copy link
Collaborator Author

vyzo commented May 8, 2020

Added some tests to explicitly test the gossip tracer and behavioural penalties.

yusefnapora
yusefnapora approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I like the change from a single scoreTracer to using a slice of internalTracers - that's nice and flexible and could maybe be useful in unit tests to capture delivery events, etc.

@vyzo vyzo merged commit 883f8b8 into master May 8, 2020
@vyzo vyzo deleted the feat/gossip-tracing branch May 8, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusefnapora yusefnapora yusefnapora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track in-flight IWANT requests
2 participants
@vyzo @yusefnapora