Strengthen Validation Of Gossip Scoring Parameters #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During further testing of our parameters for peer scoring, we came across some unusual scores for a significant amount of our peers, with a large amount giving their score as
NaN. On further investigation it came about that when initializing the scoring parameter there had been an arithmetic error when determining the parameter. This lead to the parameter being initialized with a negative infinite value. The parameter validation was unable to capture this, which is the main reason this PR has been opened up.NaNandInfinitefloating point values and throw an error if any of the topic parameters are initialized as such.