-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUIC: drop draft-29 #2478
QUIC: drop draft-29 #2478
Conversation
I believe failures in Go 1.19 are expected. |
cd13759
to
98d5063
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably make sense to split this into two PRs:
- drop 29
- update quic-go
That way, we'll be able to bisect later if we encounter any problems.
@marten-seemann could we use #2485 for the quic go update? I have also added the updated it in the subdirs similar to this PR. |
This does the minimal amount of changes to drop draft29. Along the way I ran into this issue: quic-go/quic-go#4029.
I'm torn between removing all the machinery of the multiversion quic transport or keeping it.
The reasons to keep it:
The reasons to remove it:
I'm less worried about code paths that are untrodden, because we are still exercising these codepaths. They are just used to multiplex a single option.
If we think we'll add QUIC-v2 soon (next 6 months), I think we should keep it. Open to hear other folks thoughts on this.