Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control implementations don't do error handling correctly #101

Closed
anacrolix opened this issue Apr 21, 2023 · 1 comment · Fixed by #102
Closed

Control implementations don't do error handling correctly #101

anacrolix opened this issue Apr 21, 2023 · 1 comment · Fixed by #102

Comments

@anacrolix
Copy link
Contributor

The windows implementation clobbers the error returned from SetsockoptInt with the result of the Control method call.

go-reuseport/control_windows.go

Line 10 in 194b8a8

return c.Control(func(fd uintptr) {

The unix implementation doesn't handle the error returned from the Control method call at all.

go-reuseport/control_unix.go

Line 13 in 194b8a8

c.Control(func(fd uintptr) {

@marten-seemann
Copy link
Contributor

Want to submit a patch?

anacrolix added a commit to anacrolix/go-reuseport that referenced this issue Apr 25, 2023
@anacrolix
Fix error discarding and clobbering in Control funcs
3e8ab90 
Both sockopt and control errors can't exist at the same time, but control errors should occur first, and so are given precedence.

Fixes libp2p#101
@anacrolix anacrolix mentioned this issue Apr 25, 2023
Merged
marten-seemann pushed a commit that referenced this issue Apr 25, 2023
@anacrolix
fix error handling when setting socket options (#102)
28dc065 
Both sockopt and control errors can't exist at the same time, but control errors should occur first, and so are given precedence.

Fixes #101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error discarding and clobbering in Control funcs anacrolix/go-reuseport
2 participants
@anacrolix @marten-seemann