Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

fix: event emitter and discovery and routing interfaces #95

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Apr 29, 2021

Needs to have dist folder removed (testing with lodestar for now)

Tested with ChainSafe/lodestar#2442 for last fixes. There is a fix/event-emitter-with-local-types-dist branch with the build commited to test in lodestar

This includes:

  • Event emitter change as types were not correctly exported with the previous syntax
  • Testing with lodestar types introduced issues with the interfaces that we still do not have modules with ts implemented
  • Selectors/Validator types were not accepted in lodestar ts compiler

@vasco-santos vasco-santos marked this pull request as draft April 29, 2021 11:17
@vasco-santos vasco-santos force-pushed the fix/event-emitter-with-local-types branch 6 times, most recently from 7439709 to 24a8344 Compare April 29, 2021 13:15
@vasco-santos vasco-santos force-pushed the fix/event-emitter-with-local-types branch 5 times, most recently from 9a66103 to a6ed4d7 Compare April 29, 2021 16:30
@vasco-santos vasco-santos force-pushed the fix/event-emitter-with-local-types branch from a6ed4d7 to a533ebc Compare April 29, 2021 16:34
@vasco-santos vasco-santos changed the title fix: event emitter with local types fix: event emitter and discovery and routing interfaces Apr 29, 2021
@vasco-santos vasco-santos marked this pull request as ready for review April 29, 2021 17:13
@vasco-santos vasco-santos merged commit 93ddaa4 into master Apr 30, 2021
@vasco-santos vasco-santos deleted the fix/event-emitter-with-local-types branch April 30, 2021 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants