This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
chore: replace err-code with error-code #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabcat
changed the title
|
Anything needed before doing the same to the other libp2p packages? |
|
Happy to install into libp2p* packages this week if everything is fine. Can talk about supply-chain/repo ownership if concerned. Email is on my profile. |
|
Hey we just discussed this and the supply-chain issue in our triage call. We think it would be good to maintain this under the libp2p org. |
achingbrain
added a commit
to libp2p/js-libp2p-interfaces
that referenced
this pull request
Jan 3, 2023
Adds [CodeError](libp2p/js-libp2p#1269) to errors.ts Related: libp2p/js-libp2p-crypto#284 (comment) Added public to props and code to match AbortCode style. Also recently added the custom [Error.name](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/name) property to [code-err](https://github.com/tabcat/code-err) implementation. Co-authored-by: Alex Potsides <[email protected]>
github-actions bot
pushed a commit
to libp2p/js-libp2p-interfaces
that referenced
this pull request
Jan 3, 2023
## [@libp2p/interfaces-v3.2.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interfaces-v3.1.0...@libp2p/interfaces-v3.2.0) (2023-01-03) ### Features * add CodeError ([#314](#314)) ([59aa8f7](59aa8f7)), closes [/github.com/libp2p/js-libp2p-crypto/pull/284#issuecomment-1324005434](https://github.com/libp2p//github.com/libp2p/js-libp2p-crypto/pull/284/issues/issuecomment-1324005434)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #278 which goes into more detail
Tried to find a libp2p repo that uses the props feature but was unsuccessful. Added the generic usage for props to code-err tests.
error-code package is not published yet but documentation has been added. Also the class is named and imported asErrorCodeinstead ofCodeErrorlike the OP; can change it back but thought this worked fine.@wemeetagain
Before Merging:
code-errpackage from npm