This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
fix: transport should not handle connection if upgradeInbound throws #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/transport-should-not-handle-connection-if-upgradeInbound-throws
branch
2 times, most recently
from
2760411 to
b4e0163
Compare
vasco-santos
force-pushed
the
fix/transport-should-not-handle-connection-if-upgradeInbound-throws
branch
from
b4e0163 to
7bb5448
Compare
jacobheun
reviewed
Dec 20, 2019
| await listener.listen(addrs[0]) | ||
|
|
||
| // Create a connection to the listener | ||
| const socket = await transport.dial(addrs[0]) |
There was a problem hiding this comment.
@vasco-santos I think we should validate the socket was closed as well. Since the listener throws, it should hangup, so the dial socket should get closed. We could wait for timeline.close to exist after the dial before closing everything. await pWaitFor(() => typeof socket.timeline.close === 'number') or something similar.
Other than that, this looks good. I mainly just want to ensure we are properly closing the sockets on inbound errors.
There was a problem hiding this comment.
Yeah, I think that is better
vasco-santos
force-pushed
the
fix/transport-should-not-handle-connection-if-upgradeInbound-throws
branch
from
48135da to
215282a
Compare
jacobheun
deleted the
fix/transport-should-not-handle-connection-if-upgradeInbound-throws
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed per discussion on libp2p/js-libp2p#523#discussion_r359997872