fix: replace err-code with CodeError #334
Conversation
tabcat
changed the title
tabcat
force-pushed
the
refactor/code-error
branch
from
843a672 to
5ff0b0b
Compare
|
Approach looks good. What part are you unsure of here? |
|
@wemeetagain the dependencies were locked (couldnt update them). do you know how they are bumped? Will take a closer look if you arent familiar. |
|
Sorry, I'm not familiar. I thought you'd be able to just update the relevant package.json |
|
I'll try again |
|
Yea I'm not able to update dependencies without editing package dependencies manually. Would be good to know why before I push changes. |
|
@achingbrain Do you know what is going on here? I'm not able to install/update deps with |
|
@mpetrunic would you be able to help? @tabcat mentions "I'm not sure how to bump the js-libp2p-interfaces package in js-libp2p-interfaces/packages/interface-mocks." |
I don't understand whats the issue is. PR installed deps and executed tests without an issue. |
@mpetrunic I wanted to know why the packages could not be updated before making changes. It sounds like they don't need to be changed at all so I will mark for review. |
|
Will err-code going to be removed from interface-mocks automatically? @mpetrunic |
nope, I've removed that :) |
tabcat
force-pushed
the
refactor/code-error
branch
from
b4d96ae to
b45e261
Compare
|
It looks like the error was caused by a errCode line being added upstream which after a merge caused the error. Pushing fix soon. |
Replaces [err-code](https://github.com/IndigoUnited/js-err-code/blob/master/index.js) with [CodeError](libp2p#314) Related: [js-libp2p#1269](libp2p/js-libp2p#1269) Changes - removes err-code from dependencies - adds @libp2p/[email protected] to dependencies - uses CodeError in place of err-code
tabcat
force-pushed
the
refactor/code-error
branch
from
b45e261 to
2d2261c
Compare
|
Seems good to merge? |
mpetrunic
changed the title
## [@libp2p/interface-mocks-v9.1.2](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-mocks-v9.1.1...@libp2p/interface-mocks-v9.1.2) (2023-02-22) ### Bug Fixes * replace err-code with CodeError ([#334](#334)) ([a909d41](a909d41)), closes [js-libp2p#1269](libp2p/js-libp2p#1269)
|
🎉 This PR is included in version @libp2p/interface-mocks-v9.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Replaces err-code with CodeError
Related: js-libp2p#1269
Was not sure how to update dependencies
Changes (affect interface-mocks package only)
Blockers
remove err-code from dependenciesadd @libp2p/[email protected] to dependencies