This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: tag kad-close peers #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When peers are added or removed from the kbuckets, if the `kBucketSize` closest peers change, update their peer store tags to ensure we don't close connections to them when the connection manager reaches it's max connections limit.
mpetrunic
approved these changes
Sep 30, 2022
|
I thinking maybe we want to tag them with |
I was contemplating the same but I feel like it's better if we tag them differently, on startup or pruning we can determine priorities. Like we could prune 'kad-close' tags before 'keep-alive' tags or something. Or did you mean putting two tags? |
|
I was thinking |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## [3.1.0](v3.0.6...v3.1.0) (2022-10-04) ### Features * tag kad-close peers ([#375](#375)) ([df15a83](df15a83))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When peers are added or removed from the kbuckets, if the
kBucketSizeclosest peers change, update their peer store tags to ensure we don't close connections to them when the connection manager reaches it's max connections limit.