Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

chore:use lodash main dependency #24

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

vasco-santos
Copy link
Member

In the context of #1414, I changed the lodash dependency for its main dependency.

@ghost ghost assigned vasco-santos Jul 2, 2018
@ghost ghost added the in progress label Jul 2, 2018
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, commitlint is failing because there is no space after chore:. Probably worth a quick commit amend to make ci green before merging.

@vasco-santos
Copy link
Member Author

Will amend commit message and merge! Thanks @alanshaw and @jacobheun

@vasco-santos vasco-santos force-pushed the chore/use-lodash-main-dependency branch from 7e52bf4 to 4178bd9 Compare July 3, 2018 14:09
@vasco-santos vasco-santos merged commit f95fef4 into master Jul 3, 2018
@ghost ghost removed the in progress label Jul 3, 2018
@vasco-santos vasco-santos deleted the chore/use-lodash-main-dependency branch July 3, 2018 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants