Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utp doesn't have gracious connection closing #19

Closed
dignifiedquire opened this issue Sep 14, 2016 · 6 comments
Closed

utp doesn't have gracious connection closing #19

dignifiedquire opened this issue Sep 14, 2016 · 6 comments
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@dignifiedquire
Copy link
Member

It seems the utp module is broken, so CI fails
@dignifiedquire dignifiedquire changed the title Broken UTP module Broken Sep 14, 2016
@daviddias
Copy link
Member

libutp doesn't implement the FIN flag, unfortunately, which makes thing fail.

@daviddias daviddias changed the title UTP module Broken UTP module Broken Sep 26, 2016
@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Dec 5, 2016
@daviddias daviddias added exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue and removed libp2p-backlog labels Jul 8, 2017
@daviddias daviddias added status/ready Ready to be worked and removed status/deferred Conscious decision to pause or backlog labels Sep 3, 2017
@daviddias daviddias added the P2 Medium: Good to have, but can wait until someone steps up label Feb 7, 2018
@daviddias
Copy link
Member

Work happening at #74

@daviddias daviddias self-assigned this Feb 7, 2018
@daviddias daviddias changed the title UTP module Broken utp doesn't have gracious connection closing Feb 19, 2018
@daviddias
Copy link
Member

daviddias commented Feb 19, 2018 •
edited
Loading

Crux continues to exist https://github.com/libp2p/js-libp2p-utp/pull/74/files#r169038393

@daviddias daviddias mentioned this issue Mar 19, 2018
Merged
@daviddias daviddias mentioned this issue May 5, 2018
Closed
@daviddias
Copy link
Member

daviddias commented Sep 19, 2018 •
edited
Loading

@mafintosh signaled that this situation has changed! bittorrent/libutp@04cee45 Thanks for keeping tabs on it!

Full PR here bittorrent/libutp#102

@daviddias daviddias removed their assignment Sep 19, 2018
@daviddias
Copy link
Member

utp-native now has this feature too 🎉🎉🎉

mafintosh/utp-native#5 (comment)

Thaaaaank you @mafintosh ❤️❤️❤️

@daviddias
Copy link
Member

It is all happening on #80, soon on a libp2p bundle close to you™

@daviddias daviddias mentioned this issue Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dignifiedquire @daviddias