Revamp - Update libp2p-utp to follow latest interface-connection and interface-transport #74
Conversation
daviddias
commented
Feb 7, 2018
daviddias
commented
ghost
assigned
|
|
||
| // TODO Unfortunately utp has no notion of gracious socket closing | ||
| // This feature needs to be shimmed on top to make it a proper libp2p | ||
| // transport |
There was a problem hiding this comment.
This continues to be the crux to support utp. libp2p currently expect gracious connection closing to be supported. We either remove this requirement or add a shim to libp2p-utp.
There was a problem hiding this comment.
https://github.com/bittorrent/libutp/blob/31103141c4101bc05bfe4c622cb77d17ff90c0f1/utp.h#L176
Would exposing that function via the utp-native module fix this issue?
Edit: Looks like it would: https://github.com/bittorrent/libutp/blob/abbd3df4e30f071606a616e0139251470e2c85d8/utp_internal.cpp#L3349-L3382
There was a problem hiding this comment.
Update: Calling socket.end() might fix it... investigating
https://github.com/mafintosh/utp-native/blob/master/src/socket_wrap.cc#L183-L186
There was a problem hiding this comment.
It does send fin, but for some reason only from 1 side
utp_traffic.pcapng.gz
There was a problem hiding this comment.
Another update: server.close() never emits the close event.
Edit: Didn't look in the JS code, only C++
There was a problem hiding this comment.
test/net-api.js:261: socket.end() // utp does not support half open
Just found this.
|
Merging as this PR gets it closer to the final state, however the issue with gracious closing is still present. Tracking it here #19 |
