fix: transport should not handle connection if upgradeInbound throws

[vasco-santos]

Fixed per discussion on libp2p/js-libp2p#523#discussion_r359997872

[vasco-santos]

@jacobheun I tried to do a dynamic import for the wrtc dependency, in order to get around the aegir seg fault issue. This solved the issue on lint, but not in the tests.

[jacobheun]

The segfault is happening after the tests have finished. I haven't been able to determine where it's coming from yet, but I can look into this more later this week.

[vasco-santos]

yes, I think that it is the wrtc module. But I couldn't find a work around it

[vasco-santos]

After a small research, It's seem to crash with all node versions > 10 node-webrtc/node-webrtc#636

I added a process.exit() on the aegir post hook so that we can circumvent this issue for the time being. I will also create a follow up issue in this repo to address this.

With this, I will unblock all the outdated deps and open PRs

[jacobheun]

This listener doesn't seem to be getting cleaned up anywhere. We need to make sure we're doing cleanup on the channel. I believe there is some code in the dialer that we should probably abstract out and reuse.

[vasco-santos]

I added the remove listeners.

Regarding abstracting the dialer, I think the differences are significant enough to add complexity with abstraction. I tried some changes abstracting them, but I think it made things even more confusing. These event handlers with callbacks are always not clean 😖 I think I can change the dialer to removeAllListeners instead of providing the actual callback. With that, we can abstract a clean function that cleans all the listeners, but not sure if it is worth

[jacobheun]

lgtm