Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: autoDialer backoff implementation #1899

Closed
SgtPooki opened this issue Jul 25, 2023 · 1 comment · Fixed by #1943
Closed

feat: autoDialer backoff implementation #1899

SgtPooki opened this issue Jul 25, 2023 · 1 comment · Fixed by #1943
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization

Comments

@SgtPooki
Copy link
Member

autoDialer should support configurable exponential backoff, or retry policies, for multiaddr that have consistently failed to establish a connection:

related to
@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Jul 25, 2023
@maschad maschad moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p Jul 26, 2023
@maschad maschad added the kind/enhancement A net-new feature or improvement to an existing feature label Jul 26, 2023
@maschad
Copy link
Member

maschad commented Aug 1, 2023

Discussion from Open Maintainers call on 1/08/2023

Potential solution:

Penalize peers / multiaddrs via decreasing their tag value if dials are failing / rejected dials so that they are moved lower in the dial-queue.

cc @achingbrain

@maschad maschad mentioned this issue Aug 9, 2023
Merged
achingbrain added a commit that referenced this issue Aug 16, 2023
@achingbrain
feat(libp2p): add autodial retry threshold config option (#1943)
4ef9c79 
When auto-dialing peers, if we have failed to dial them recently there's little point in redialing them as it's probably just going to fail again which consumes a slot in the dial queue and other resources.

Adds a `autoDialPeerRetryThreshold` config key to the connection manager which is a value in ms.

If we have attempted to dial a peer and that dial attempt failed but we are under our min connection count, do not auto dial the peer within the retry threshold.

Defaults to 1 minute.

Closes #1899
@github-project-automation github-project-automation bot moved this from 🥞Weekly Candidates/Discuss🎙 to 🎉Done in js-libp2p Aug 16, 2023
@maschad maschad mentioned this issue Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(libp2p): add autodial retry threshold config option libp2p/js-libp2p
2 participants
@SgtPooki @maschad