fix: replace err-code with CodeError #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabcat
changed the title
|
Two options to handle the .props breaking change wrt err-code -> CodeError
|
tabcat
changed the title
|
we'll want to go with this option:
|
|
Ill start looking for those cases then in ipfs/libp2p and other related dependents |
|
From what I could find from the dependents on npm, this doesnt seem to be used internally. It is documented in the code as an API. Will need to update that. |
tabcat
changed the title
tabcat
force-pushed
the
chore/code-error
branch
from
6a62f0b to
2393be2
Compare
tabcat
commented
Feb 15, 2023
src/keychain/cms.ts
Outdated
Comment on lines
127
to
129
| throw errCode(new Error(`Decryption needs one of the key(s): ${missingKeys.join(', ')}`), codes.ERR_MISSING_KEYS, { | ||
| throw new CodeError(`Decryption needs one of the key(s): ${missingKeys.join(', ')}`, codes.ERR_MISSING_KEYS, { | ||
| missingKeys | ||
| }) |
There was a problem hiding this comment.
This is the only piece of code affected by the props change in CodeError across all of the libp2p packages.
tabcat
commented
Feb 15, 2023
src/keychain/cms.ts
Outdated
| * exists, an Error is returned with the property 'missingKeys'. It is array of key ids. | ||
| * exists, an Error is returned with the property '.props.missingKeys'. It is array of key ids. |
There was a problem hiding this comment.
Let me know if this needs to be reworded.
chore: upgrade @libp2p/interfaces to v3.2.0 chore: remove err-code from deps replace errCode imports with CodeError replace errCode implementations with CodeError
tabcat
changed the title
|
Since the keychain has been moved to it's own repo this is no longer a breaking change. |
Merged
achingbrain
changed the title
achingbrain
approved these changes
Mar 20, 2023
|
Thanks for opening this and having such patience. We got there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces err-code with CodeError
Related: #1269
Changes
BlockersDecide how to handle .props breaking changeerr-code exposes properties inside its props parameter directly from the error object (e.g. error.someProp). CodeError exposes them from the provided props parameter (e.g. error.props.someProp) (see: js-libp2p/crypto#278 CodeError behavior vs. errcode).https://github.com/libp2p/js-libp2p/pull/1532/files#diff-f7c06d53ddde550172379d5951eb28536d95404fa767ee9d986a8fdae34ddd56L127-L130