chore: add error codes to dht and pubsub errors #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
It would be good to have the codes exported from a constants file so we don't risk miss typing them. Also, most of the nextTick logic could probably just have the anonymous function removed since it doesn't need any local references. nextTick(callback, errCode(new Error('DHT is not available'), 'ERR_DHT_DISABLED')) |
vasco-santos
force-pushed
the
chore/add-error-codes-to-dht-and-pubsub-errors
branch
from
097543f to
a3271ec
Compare
|
Thanks @jacobheun That should be fixed |
jacobheun
suggested changes
Feb 20, 2019
vasco-santos
force-pushed
the
chore/add-error-codes-to-dht-and-pubsub-errors
branch
3 times, most recently
from
7cfb25c to
58d49d5
Compare
|
I added tests for all of those! |
vasco-santos
force-pushed
the
chore/add-error-codes-to-dht-and-pubsub-errors
branch
from
58d49d5 to
f3f4d46
Compare
|
@vasco-santos it looks like linting needs to be fixed in the tests. |
vasco-santos
force-pushed
the
chore/add-error-codes-to-dht-and-pubsub-errors
branch
from
f3f4d46 to
e4ae152
Compare
jacobheun
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error codes to the dht and pubsub errors, as well as replaced
setImmediatebynextTick.In the context of ipfs/js-ipfs#1879