review: apply review suggestions

libp2p · Sep 28, 2022 · a91701e · a91701e
1 parent b0da4d8
commit a91701e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 11 deletions.
diff --git a/protocols/identify/CHANGELOG.md b/protocols/identify/CHANGELOG.md
@@ -2,12 +2,6 @@
 
 - Update dependencies.
 
-# 0.39.0
-
-- Update to `libp2p-swarm` `v0.39.0`.
-
-- Update to `libp2p-core` `v0.36.0`.
-
 - Rename types as per [discussion 2174].
   `Identify` has been renamed to `Behaviour`.
   The `Identify` prefix has been removed from various types like `IdentifyEvent`.
@@ -16,6 +10,18 @@
 
   [discussion 2174]: https://github.com/libp2p/rust-libp2p/discussions/2174
 
+# 0.39.0
+
+- Update to `libp2p-swarm` `v0.39.0`.
+
+- Update to `libp2p-core` `v0.36.0`.
+
+# 0.39.0
+
+- Update to `libp2p-swarm` `v0.39.0`.
+
+- Update to `libp2p-core` `v0.36.0`.
+
 # 0.38.0
 
 - Update prost requirement from 0.10 to 0.11 which no longer installs the protoc Protobuf compiler.

diff --git a/protocols/identify/src/behaviour.rs b/protocols/identify/src/behaviour.rs
@@ -77,7 +77,7 @@ enum Reply {
     },
 }
 
-/// Configuration for the [`Behaviour`] [`NetworkBehaviour`].
+/// Configuration for the [`identify::Behaviour`](Behaviour).
 #[non_exhaustive]
 #[derive(Debug, Clone)]
 pub struct Config {

diff --git a/protocols/identify/src/lib.rs b/protocols/identify/src/lib.rs
@@ -35,7 +35,7 @@
 //!
 //! # Usage
 //!
-//! The [`Behaviour`] struct implements a `NetworkBehaviour` that negotiates
+//! The [`Behaviour`] struct implements a [`NetworkBehaviour`] that negotiates
 //! and executes the protocol on every established connection, emitting
 //! [`Event`]s.
 //!
@@ -48,18 +48,18 @@ pub use self::behaviour::{Behaviour, Config, Event};
 pub use self::protocol::{Info, UpgradeError, PROTOCOL_NAME, PUSH_PROTOCOL_NAME};
 
 #[deprecated(
-    since = "0.39.0",
+    since = "0.40.0",
     note = "Use re-exports that omit `Identify` prefix, i.e. `libp2p::identify::Config`"
 )]
 pub type IdentifyConfig = Config;
 
 #[deprecated(
-    since = "0.39.0",
+    since = "0.40.0",
     note = "Use re-exports that omit `Identify` prefix, i.e. `libp2p::identify::Event`"
 )]
 pub type IdentifyEvent = Event;
 
-#[deprecated(since = "0.39.0", note = "Use libp2p::identify::Behaviour instead.")]
+#[deprecated(since = "0.40.0", note = "Use libp2p::identify::Behaviour instead.")]
 pub type Identify = Behaviour;
 
 mod behaviour;