Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to pass metadata from the transport to the protocols handler #1030

Closed
tomaka opened this issue Mar 29, 2019 · 2 comments
Closed

Make it possible to pass metadata from the transport to the protocols handler #1030

tomaka opened this issue Mar 29, 2019 · 2 comments
Labels
difficulty:moderate priority:nicetohave

Comments

@tomaka
Copy link
Member

tomaka commented Mar 29, 2019

At the moment, the SecioOutput contains the ephemeral key used during negotiation, but since the Swarm requires the transport output to be (PeerId, impl StreamMuxer), we have no way to pass it around.

This is required for paritytech/substrate#271
@tomaka tomaka added priority:important The changes needed are critical for libp2p, or are blocking another project difficulty:moderate labels Mar 29, 2019
@tomaka tomaka mentioned this issue Apr 4, 2019
Merged
@tomaka tomaka mentioned this issue Jun 11, 2019
Closed
@tomaka tomaka added priority:nicetohave and removed priority:important The changes needed are critical for libp2p, or are blocking another project labels Feb 27, 2020
@tomaka
Copy link
Member Author

tomaka commented Feb 27, 2020

We don't need it anymore in Substrate, so I'm going to lower the priority tag.

@thomaseizinger
Copy link
Contributor

Closing in favor of #2946.

@thomaseizinger thomaseizinger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:moderate priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomaka @thomaseizinger