Generalize TPeerId into TConnInfo #1045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of #1030
At the moment, the structs in the
nodes
module have aTPeerId
parameter that notably requiresEq + Hash
.This PR turns
TPeerId
intoTConnInfo
, and introduces a new trait thatTConnInfo
must implement:By default, a
TConnInfo
is aPeerId
. But after this PR, it can consist of anything that contains aPeerId
.