[libp2p-ping] Properly close the substream in the InboundUpgrade. #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not doing so may result in FIN/RST frames being sent before earlier data frames. See libp2p/rust-yamux#81 (comment).
tomaka
approved these changes
Jun 12, 2020
mxinden
approved these changes
Jun 12, 2020
This was referenced Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not doing so may result in FIN/RST frames being sent and received before earlier data frames. See libp2p/rust-yamux#81 (comment). This seems to be the cause for paritytech/substrate#6311 as it creates a possible race whereby FIN/RST frames may be received before data frames, causing ping upgrade failures.