Pass the host name in libp2p-websockets #177
Conversation
ghost
assigned 
|
The even more correct :) solution is to properly define the /http and /ws multiaddrs as including data for a Host header. URLs are a mess in this regard, their hostname is used for 3 (!) things at once: DNS resolution, TLS SNI header, and the HTTP Host header. Related: multiformats/multiaddr#63 (comment) |
|
@lgierth It's not very clear, but including the hostname in the |
| let protocols: Vec<_> = client_addr.iter().collect(); | ||
|
|
||
| if protocols.len() != 2 { | ||
| "127.0.0.1".to_owned() |
There was a problem hiding this comment.
Shouldn't we error in case the address does not conform to the required format?
There was a problem hiding this comment.
Whatever this function returns, what we do in reality is pass the inner multiaddress to the underlying transport, then negotiate websockets over the socket provided by the underlying transport. Therefore the actual IP address here doesn't matter.
If the multiaddr is
/dns4/.../wsfor example, then the corresponding hostname will be passed in the headers of the websocket HTTP request.This is important if the listener is behind an HTTP reverse proxy, as the same IP address may dispatch to multiple websites.
This means that the WebSockets layer should be on top of the DNS layer in the transport. The fact that the user can make a mistake here sucks, but I don't see any better solution.