Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transports/tls: Add
libp2p-tls
as per spec #2945transports/tls: Add
libp2p-tls
as per spec #2945Changes from 48 commits
06a77c2
5364b43
71b2fe8
80c0d1c
03a2aed
c5b1558
2316505
334544d
4d6db82
e4547a5
3267ccd
9a9ac2b
b810bcc
7c6e6cf
a8d965f
6d68ffa
21b4319
f0cac36
39fdf41
3b76e39
3ddf442
d0bb3fa
01ecdbc
67eda94
eedbefc
d9f1036
d74fe57
eaa27f4
f95e9d9
7acf98b
4f15b3b
e1f34ae
79a464a
59ebdb2
a1546be
f6ba989
4a5c4da
d078a5e
d9c999a
d362aef
10b4c82
e4e7bfd
6bb6ce7
2ac833e
6e03126
1edc6f3
fbb0d3a
a3af017
f11c54e
bf1b30a
59c43ce
3fe6386
ed98810
f5bf544
eae9b5f
27b58f7
b01bff4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To the best of my knowledge, the code below has not run in any production systems.
To communicate expectations, I suggest releasing this as an alpha first.
See also same suggestion on QUIC pull request #2289 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it!
Most users depend on
libp2p
though so they are not going to see this version. IMO we are effectively removing that "alpha" label again through the re-export.Do you think we should perhaps not re-export the TLS implementation yet so users have to depend on it manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is true. Though I would explicitly call it out in the changelog.
I don't have an opinion here. I think we should be consistent with
libp2p-quic
. Chatted with @elenaf9 quickly. She prefers not removinglibp2p-quic
fromlibp2p
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about annotating the re-export with the
unstable
attribute macro @thomaseizinger ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is specific to the Rust compiler from what I know, I don't think you can use that actually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes you are right! Don't have a strong on opinion on whether to re-export tls and quic or not. I did not consider that when re-exporting we "hide" the alpha-flag, so maybe not re-exporting is the best solution after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think not exporting it would be the better solution but I don't want to block this PR on it. We can always change that until the next release.