-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swarm): Add wasm-bindgen
executor
#3115
Conversation
Co-authored-by: Thomas Eizinger <[email protected]>
Co-authored-by: Thomas Eizinger <[email protected]>
Co-authored-by: Thomas Eizinger <[email protected]>
…p2p into executor-aware-swarm
Co-authored-by: Thomas Eizinger <[email protected]>
Co-authored-by: Thomas Eizinger <[email protected]>
Co-authored-by: Thomas Eizinger <[email protected]>
Co-authored-by: Thomas Eizinger <[email protected]>
Co-authored-by: Thomas Eizinger <[email protected]>
wasm-bindgen
executor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @umgefahren for the work here!
From my minimal WASM knowledge, this looks good to me.
@vincev curious what your thoughts are here given your example #2617 (comment).
@mxinden looks nice it makes it easier to create the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rustfmt is not happy, otherwise this LGTM!
This pull request has merge conflicts. Could you please resolve them @umgefahren? 🙏 |
After merging #3083 which touched the mergify configuration, Mergify is complaining that "The current Mergify configuration is invalid", see also https://github.com/libp2p/rust-libp2p/pull/3115/checks?check_run_id=9673900404.
Unfortunately I don't have access to the libp2p Mergify subscription page, thus I am not sure what it entails to "update the subscribtion". @galargh do you have access? Can you check what we would need to do to "update the subscription"? //CC @thomaseizinger |
Oh my god :( https://docs.mergify.com/actions/post_check/#enforcing-conventional-commits post_check's are a premium feature! I completely overlooked that! Sorry about that. I suggest we revert #3083 for now. |
You do have access to the dashboard though, right? |
I do. Is there some way that is helpful? |
Only to inspect the current merge queue. I just wanted to make sure this isn't tied to my account only for some reason. |
Description
Add a
wasm-bindgen
executor to perform concurrent connections on browser or node background tasks.Links to any relevant issues
Result of: #3097 (comment)
Open Questions
None
Change checklist
Commit message body