-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): properly escape PR title #3318
Conversation
command
Draft until I have confirmed that this works. |
In case another example is needed: https://github.com/libp2p/rust-libp2p/actions/runs/3893266711/jobs/6645662828 |
command
Proof that it is working: https://github.com/libp2p/rust-libp2p/actions/runs/3907325150/jobs/6676432195#step:3:10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Within double quoted strings, bash tries to evaluate everything within backticks as a command. The GitHub security guide recommends to use an intermediary environment variable instead: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
See https://github.com/libp2p/rust-libp2p/actions/runs/3889880383/jobs/6638520274#step:3:11.
Notes
Links to any relevant issues
Open Questions
Change checklist