test(swarm): Wait for swarm1 to disconnect

[mxinden]

Description

This commit does two things:

• Check that swarm1, given that it has no ban, establishes 21 connections and swarm2, given that it has a ban, establishes 20 connections.

• Wait for swarm1 to notice disconnect, given that swarm2 closed the connection to the banned swarm1.

Fixes flake introduced in caed1fe.

Notes

Links to any relevant issues

Open Questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[thomaseizinger]

Thanks!

I don't fully understand why it was flaky before. Should go away soon anyway :)

[mxinden]

Sorry, I didn't do a good job writing a pull request description.

                    if swarm1.behaviour.on_connection_established.len() == s1_expected_conns
                        && swarm2.behaviour.assert_connected(s2_expected_conns, 2)

s1_expected_conns did not account for swarm1 establishing the banned connection, i.e. it was 20, but should be 21. In case swarm2 going to 20 before swarm1 going to 21, the test would succeed. Otherwise it would not.

Thanks for the review. Merging here to unblock other pull requests.