Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(noise): remove deprecated legacy handshakes #3511

Merged
merged 35 commits into from
May 8, 2023
Merged

feat(noise): remove deprecated legacy handshakes #3511

merged 35 commits into from
May 8, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Feb 27, 2023 •
edited
Loading

Description

This patch removes all deprecated legacy code from libp2p-noise and attempts to collapse all the abstraction layers into something a lot simpler.

Notes

Patch-by-patch review is recommended.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added this to the v0.52.0 milestone Feb 27, 2023
mxinden
mxinden previously approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@mergify

This comment was marked as resolved.

Sign in to view
@mergify

This comment was marked as resolved.

Sign in to view
@mergify

This comment was marked as resolved.

Sign in to view
@thomaseizinger thomaseizinger changed the title feat(noise): remove deprecated legacy handshake feat(noise): remove deprecated legacy handshakes May 1, 2023
@mergify

This comment was marked as resolved.

Sign in to view
@thomaseizinger thomaseizinger marked this pull request as ready for review May 2, 2023 12:43
@mergify

This comment was marked as resolved.

Sign in to view
mxinden
mxinden previously approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean-up!

@mxinden mxinden added the send-it label May 4, 2023
@thomaseizinger thomaseizinger requested a review from mxinden May 4, 2023 07:54
@mergify

This comment was marked as resolved.

Sign in to view
@mergify mergify bot merged commit b507fe2 into master May 8, 2023
@mergify mergify bot deleted the ft/remove-legacy-noise-impl branch May 8, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
v0.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden