-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(webtransport-websys): Change logs to debug level #5396
Conversation
This pull request has merge conflicts. Could you please resolve them @oblique? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can confirm, it's really noisy
Co-authored-by: Maciej Zwoliński <[email protected]>
For some reason CI got stuck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Interesting cargo-semver-checks
does not complain, in fact I'd be more comfortable releasing this as a new minor wdyt?
Do you mean 0.3.0? I'm ok with it. |
yeah exactly, ok thanks |
Question: In that case we will need to wait for libp2p 0.54 to incorporate this and #5390 in our crate. Do you have an approximate date for the release? Do you work with release cycles? |
we're waiting on #5389 to release a new |
Sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When you enable Kademlia in a large network that uses multiple type of transports, then this log creates a very noisy console and makes meaningful logs hard to see. We can also remove the log entirely if you prefer. Check: libp2p#4015 (comment), libp2p#4072, libp2p#4133 Pull-Request: libp2p#5396.
Description
When you enable Kademlia in a large network that uses multiple type of transports, then this log creates a very noisy console and makes meaningful logs hard to see.
We can also remove the log entirely if you prefer. Check: #4015 (comment), #4072, #4133
Notes & open questions
Change checklist