Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: dialMe protocol #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

RFC: dialMe protocol #64

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d1c23c
feat: adding dialme protocol
dryajov May 29, 2018
b826284
fix: reword requirements
dryajov May 30, 2018
89075f0
feat: change addrs field to string, to prevent sending multiple multi…
dryajov May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dialme/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ This is a rather simple protocol that communicates a multiaddress to perform the
message DialMe {
message Peer {
required bytes id = 1; // peer id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't include this, the remote side should already know our peer ID and we definitely don't want to end up dialing a different peer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I agree with you, I can't think of a use for this honestly. Unless anyone objects I'll remove it.

repeated bytes addrs = 2; // array of multiadrs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit should have changed repeated to optional (unless I'm missing something).

repeated string addrs = 2; // a multiaddr to dial the the peer over
}

optional Peer peer = 1;
Expand Down