feat(perf): add (automation, provision, build, run) tooling #184
Conversation
See `perf/README.md`.
I will consolidate the outstanding follow-ups once this is merged on #63. |
Sounds good to me. Added to the top of follow-ups to this pull request. @MarcoPolo thank you for the review! I addressed all your comments. Would you mind taking another look? Anything else missing? |
perf/impl/https/v0.1/main.go
Outdated
| type customReader struct { | ||
| downloadBytes uint64 | ||
| uploadBytes uint64 | ||
| position uint64 | ||
| } |
There was a problem hiding this comment.
Can we just copy-paste the perf implementation we have in the v0.27 folder? The Read implementation here looks quite complicated.
There was a problem hiding this comment.
The impl/go-libp2p/v0.27 implementation leverages the io.Writer interface on network.Stream interface. I don't know how to have the Go std http library provide an object that implements io.Writer interface for an HTTP request. Instead all the methods that I am aware of require passing an io.Reader for an outgoing HTTP request, i.e. client.Post and http.NewRequest.
@marten-seemann are you aware of an alternative?
perf/impl/https/v0.1/main.go
Outdated
| if c.position < 8 { | ||
| binary.BigEndian.PutUint64(p, c.downloadBytes) | ||
| c.position += 8 | ||
| return 8, nil |
There was a problem hiding this comment.
This isn't correct. You're assuming the input slice is always at least 8 bytes.
Use io.MultiReader to combine a bytes.NewReader(<buf-with-u64-download-bytes>) and a zeroReader.
The zeroReader could look something like:
type zeroReader struct {
n int64
}
func (z *zeroReader) Read(p []byte) (int, error) {
if z.n <= 0 {
return 0, io.EOF
}
for i := range p {
if z.n <= 0 {
return i, nil
}
p[i] = 0
z.n--
}
return len(p), nil
}
There was a problem hiding this comment.
Wasn't aware of io.MultiReader. That simplifies things. Thanks!
Fixed with 2296d8c. Note that I am still using copy instead of zeroing every byte individually in the (maybe premature) hope that Go can optimize some of it. Let me know in case you prefer individual zeroing for each byte instead @MarcoPolo.
Edit:
Slight change of plan, instead of 2296d8c I merged @marten-seemann's suggestion through #201.
|
Looks good mod last comment about the reader. |
There was a problem hiding this comment.
LGTM, let's ship it!
There's a few follow-up items to this PR, but what we have here is an excellent basis to start iterating on.
Thank you for this clean setup @mxinden, I'm really happy how this turned out
Instead of exposing the time to establish a connection, the time to upload the bytes and the time to download the bytes, expose a single time including all three. The rational here is, that differentiation of the three is flawed. E.g. when does one stop the upload timer and start the download timer? When the last byte is sent? When the last byte is flushed? When the first byte is received? See libp2p/test-plans#184 (review) for past discussion.
Instead of exposing the time to establish a connection, the time to upload the bytes and the time to download the bytes, expose a single time including all three. The rational here is, that differentiation of the three is flawed. E.g. when does one stop the upload timer and start the download timer? When the last byte is sent? When the last byte is flushed? When the first byte is received? See libp2p/test-plans#184 (review) for past discussion.
Instead of exposing the time to establish a connection, the time to upload the bytes and the time to download the bytes, expose a single time including all three. The rational here is, that differentiation of the three is flawed. E.g. when does one stop the upload timer and start the download timer? When the last byte is sent? When the last byte is flushed? When the first byte is received? See libp2p/test-plans#184 (review) for past discussion. Pull-Request: #4105. Co-Authored-By: Max Inden <[email protected]>
Description
See
perf/README.mdand overarching tracking issue #63.Continuation of #163.
Outstanding work in this pull request:
--n-timesflag from binaries. Potentially introduce--n-parallel-requestsflag in the future. Multiple sequential runs are now done in the runner implementation.--secret-key-seed.### Outstanding work for future pull requests:Outstanding / follow-up work tracked in #63.