Add rustdoc to connect crate #1455
Open
+403
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- CHANGELOG.md: Evaluated as low risk
- connect/README.md: Evaluated as low risk
- connect/src/lib.rs: Evaluated as low risk
- connect/src/model.rs: Evaluated as low risk
- connect/src/state/metadata.rs: Evaluated as low risk
- src/main.rs: Evaluated as low risk
roderickvd
reviewed
Jan 22, 2025
|
When you're looking for anyone's review, you can specifically request / add them as reviewers and keep the assignee as yourself. |
Okay will do! You just said in another message that I should assigning you, but I suppose I mistook assigning to the PR with review assigning. |
|
Oh and big thanks for the review @roderickvd :D |
photovoltex
force-pushed
the
connect-docs
branch
2 times, most recently
from
fd6de96 to
bed00a6
Compare
photovoltex
force-pushed
the
connect-docs
branch
from
bed00a6 to
1416fd2
Compare
roderickvd
reviewed
Jan 28, 2025
photovoltex
force-pushed
the
connect-docs
branch
from
ac9b064 to
8fac548
Compare
|
When there aren't any points left to address, I will merge it sometime the following days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I initially tried to enforce rustdoc on the whole project, but that just is in insane task at this stage.
Well anyhow... I got around to add rustdoc for the connect crate and additionally a cleanup of the exposed items, so that only the necessary are exposed.
I also had to change up the
CHANGELOG.mdas some previous entries where are out of that with the cleanup changes.