-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples #663
Update examples #663
Conversation
Thanks! I'm sorry I removed the |
I feel like the default impl is a more ergonomic, and that a builder pattern is not necessarily warranted for a struct with 4 fields. |
I also feel like the examples could be nicer without the |
I reintroduced the old Default impl, be reintroducing the dependency on |
Looks good, but there are merge conflicts. You should rebase it (and maybe squash it into 1 or 2 commits while you're at it). And then I think it's ready. |
@ThouCheese Would you do this? |
Re-add default impl to SessionConfig and make Credentials::with_password generic over Into<String> add docs for Credential reintroduce old Default impl for SessionConfig use the third argument for the track-to-play rather than a testing id
92fb1cb
to
ec1ec59
Compare
Hi! Yes sorry that took so long, I had to fight a bit with git rebase (that is, learn how it works). Currently 1 commit and no conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Even better if you've learned something new.
Updated the examples to run with tokio 1.0.