-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak dependencies #710
Tweak dependencies #710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think the new zerocopy
requires an even higher MSRV? Likewise the new sdl2
uses some previously experimental features.
While you're at it, there's a new |
We don't use libc anywhere directly? Let's try MSRV 1.48 next. This is the rustc version of the upcoming debian release. |
It's here: Line 33 in cc9d6f5
But you're right it's only a dependency for various backends and I think |
Let's see whether this works |
|
hyper, libmdns and sdl require a higher version.
I just tried and it's OK to update diff --git a/playback/Cargo.toml b/playback/Cargo.toml
index b8736db..92bfb4a 100644
--- a/playback/Cargo.toml
+++ b/playback/Cargo.toml
@@ -31,7 +31,7 @@ libpulse-binding = { version = "2", optional = true, default-features = f
libpulse-simple-binding = { version = "2", optional = true, default-features = false }
jack = { version = "0.6", optional = true }
libc = { version = "0.2", optional = true }
-sdl2 = { version = "0.34.3", optional = true }
+sdl2 = { version = "0.34", optional = true }
gstreamer = { version = "0.16", optional = true }
gstreamer-app = { version = "0.16", optional = true }
glib = { version = "0.10", optional = true }
|
|
Ah I see, thanks. |
(most notably: the crates aes and aes-ctr were unified)but not aes since it requires rust 1.49.Bumped zerocopy from 0.3 to 0.5.(Needs rust version 1.51)rm Cargo.lock && cargo +nightly build -Z minimal-versions
work, but it's a step into the right direction.