Hook ML-KEM related tests #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds ML-KEM related tests.
|
Linux's and emscripten's ASAN will be failed. These need to be fixed in some main codes discussed in this thread https://marc.info/?l=openbsd-tech&m=173441751232320&w=2 |
|
Great, thanks! This pretty much matches what I had planned to do but didn't get around to doing yet (in particular testing with ASAN) yet. I have synced your fixes from tech@, so please rebase this PR on top of master. (some of the test failures (arm32 and one of the ASAN tests) seem to be due to github CI instability. |
|
Ah, apparently there's no need. Retriggering the test seems to pick up the fixed source. I'll merge once all is green. Many thanks! |
|
Yes, thank you as well for your prompt response! |
botovq
added a commit
to botovq/libressl-portable
that referenced
this pull request
Dec 17, 2024
- Run the 1024 iteration test as well as unit tests. - Remove unused test script with unexpected contents. Follow-on to libressl#1127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds ML-KEM related tests.