Skip to content

Commit

Permalink
VisualC/pkg-support/cmake: remove subdir from public header include path
Browse files Browse the repository at this point in the history
  • Loading branch information
@sezero
sezero committed Sep 30, 2023
1 parent 61e9a9d commit 47cba08
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion VisualC/pkg-support/cmake/sdl3-config.cmake
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ else()
endif()

set_and_check(_sdl3_prefix "${CMAKE_CURRENT_LIST_DIR}/..")
set(_sdl3_include_dirs "${_sdl3_prefix}/include;${_sdl3_prefix}/include/SDL3")
set(_sdl3_include_dirs "${_sdl3_prefix}/include")
unset(_sdl3_prefix)

set(SDL3_LIBRARIES SDL3::SDL3)
Expand Down

6 comments on commit 47cba08

@sezero
Copy link
Contributor Author

@sezero sezero commented on 47cba08 Sep 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are the CI intel compiler runs failing?

@madebr
Copy link
Contributor

@madebr madebr commented on 47cba08 Sep 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I"m not entirely sure, but if it isn't a transient error, I'm inclined to remove it from ci. It's not like the intel compiler caught bugs not reported by other platforms.
Looking at this example workflow, it looks like the new way is to download, cache and install the toolchain yourself.

@madebr
Copy link
Contributor

@madebr madebr commented on 47cba08 Sep 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction, apt is still supported: https://github.com/oneapi-src/oneapi-ci/blob/master/scripts/setup_apt_repo_linux.sh

@madebr
Copy link
Contributor

@madebr madebr commented on 47cba08 Sep 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a matter of expired keys: oneapi-src/oneapi-ci#77

@madebr
Copy link
Contributor

@madebr madebr commented on 47cba08 Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled testing intel compilers on the main and SDL2 branch.

@sezero
Copy link
Contributor Author

@sezero sezero commented on 47cba08 Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone did this as a workaround: Are we interested?

Please sign in to comment.