Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipewire: Add support for session detection #5304

Closed
flibitijibibo opened this issue Feb 4, 2022 · 5 comments
Closed

pipewire: Add support for session detection #5304

flibitijibibo opened this issue Feb 4, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@flibitijibibo
Copy link
Collaborator

This issue is a little unusual because the PipeWire feature doesn't actually exist yet! But, this seems to be the way that the detection problem will be solved, and the WirePlumber draft is here:

https://gitlab.freedesktop.org/pipewire/wireplumber/-/merge_requests/313

I would write this under the assumption that George's formatting for the key will be how it's implemented, rather than a boolean.

I'd like to have this written up early so that A: WirePlumber devs have more data to test against, and B: it ensures that the key actually does what we want on our end, and we can merge it into main the moment the feature is frozen for the next PW release.

Blocker for #5268

CC @Kontrabant

@flibitijibibo flibitijibibo added the enhancement New feature or request label Feb 4, 2022
@Kontrabant
Copy link
Contributor

Just to note that I've started to work on this locally, so I'll have the WIP branch available in the not too distant future.

@flibitijibibo flibitijibibo self-assigned this Mar 24, 2022
@flibitijibibo flibitijibibo changed the title pipewire: Add support for PW_KEY_SESSION_INITIALIZED pipewire: Add support for session detection Apr 7, 2022
@flibitijibibo
Copy link
Collaborator Author

flibitijibibo commented Apr 7, 2022

Changing this one a tiny bit - some discussion for session detection in the OP's MR ended up leaning toward doing this in a more nuanced way, mainly the idea that session detection should include checking for a session that actually involves audio in some way (which it actually might not). So at the moment the graph looks a bit like this:

WirePlumber adds better async support for plugin initialization -> WirePlumber can implement a better async session startup -> SDL can detect sessions robustly

@flibitijibibo
Copy link
Collaborator Author

The PipeWire side is being investigated with the help of Eden Industries, the branches can be found here:

https://gitlab.freedesktop.org/antonio.ilersich/pipewire/-/tree/1835-session-detection
https://gitlab.freedesktop.org/antonio.ilersich/wireplumber/-/tree/1835-session-detection

Any eyeballs on this are welcome, as we'd like to have this ready to use by the end of this year!

@flibitijibibo
Copy link
Collaborator Author

WIP MRs are live:

https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1409

https://gitlab.freedesktop.org/pipewire/wireplumber/-/merge_requests/441

The goal is still to implement this entirely in PW, so if you're looking at this feature then the above MRs are where you want to be!

@slouken slouken added this to the 3.x milestone Nov 7, 2023
@Kontrabant
Copy link
Contributor

Obsoleted by #9473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants