[DONOTMERGE] pipewire: Check for an audio session before initializing #5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pretty much all makes sense - next step is to see what the PW/WP maintainers think, I'll take care of this today. |
flibitijibibo
changed the title
Kontrabant
force-pushed
the
pipewire_detect_session
branch
from
86a924f to
a1629c8
Compare
Kontrabant
force-pushed
the
pipewire_detect_session
branch
from
a1629c8 to
8c45de9
Compare
Check if the session supports audio and fail if audio support is not present.
Kontrabant
force-pushed
the
pipewire_detect_session
branch
from
8c45de9 to
178cbdf
Compare
|
Updated to work with the current WIP session service code. Needs both the Pipewire and Wireplumber changes to test: https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1409 |
|
Forgot to mention over on this side: The patches above are open for anyone to take over, as the author had to return to other work! From what I can tell it's really close, just needs addressing of a couple comments and some overall cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is the preliminary, experimental code to detect whether or not Pipewire is managing the audio session during initialization. This is very WIP, should not be merged, and currently only works with Peter Hutterer's experimental Wireplumber branch at https://gitlab.freedesktop.org/whot/wireplumber/-/tree/wip/session-initialized-property
Strictly for testing only.
The following upstream issues track the progress of session status reporting:
For now, it looks for the 'session.initialized' property and checks if it is set to a non-zero value or contains the string 'audio' somewhere in it. If the property is present and everything is initialized, the backend initialization succeeds. If it is present but uninitialized, a timed wait is used to wait for initialization to complete. If initialization is not complete within the specified period (currently 3 seconds), the backend initialization fails. If the 'session.initialized' property is not found at all, the backend initialization fails. The session check is, however, completely bypassed if the Pipewire backend is explicitly forced on via the SDL_AUDIODRIVER envvar.
Fixes #5304, part of #5268
@flibitijibibo