Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep logs longer #1055

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

MarkZH
Copy link
Collaborator

@MarkZH MarkZH commented Dec 13, 2024

Type of pull request:

  • Bug fix
  • Feature
  • Other

Description:

Preserve automatic logs for a longer time to aid debugging. The log files will rollover to a new file at midnight, and seven days of log files will be preserved.

Related Issues:

#1053, where needed information was lost due to lichess-bot restarting after a dropped connection.

Checklist:

  • I have read and followed the contribution guidelines.
  • I have added necessary documentation (if applicable).
  • The changes pass all existing tests.

Screenshots/logs (if applicable):

N/A

MarkZH and others added 4 commits December 11, 2024 02:56
The log files will be rotated every day at midnight. Up to seven days of
backup logs will be kept.
In case the user keeps lichess-bot running for more than seven days, log
the user's configuration after midnight so it is always available for
debugging.
So there's no need to interrupt the log file with configuration
information that is likely irrelevant at that point.
@AttackingOrDefending AttackingOrDefending merged commit 9a7b2ee into lichess-bot-devs:master Dec 13, 2024
23 checks passed
@MarkZH MarkZH deleted the keep-logs-longer branch December 14, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants