ui/nvui cleanup #16560
Merged
ui/nvui cleanup #16560
+641
−825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strike down the tower of babel
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
great stuff |
… for nvui to parse dests
|
Gonna stop myself for now so that future bug fixing can be a bit more manageable |
ornicar
reviewed
Jan 13, 2025
| @@ -10,7 +10,6 @@ export const render = (ctrl: AnalyseCtrl): VNode => | |||
| h('div.cg-wrap.cgv' + ctrl.cgVersion.js, { | |||
| hook: { | |||
| insert: vnode => ctrl.setChessground(makeChessground(vnode.elm as HTMLElement, makeConfig(ctrl))), | |||
| destroy: _ => ctrl.chessground.destroy(), | |||
There was a problem hiding this comment.
how did you determine that this could be removed?
There was a problem hiding this comment.
Nvui relies on chessground to keep track of board state. That line destroys the initialized chessground state whenever the main analysis board is removed from the DOM tree (which is the order of operations on every analysis/study page load)
|
Looking good! Please see my question above before I merge. |
|
Just noticed there is a bug where chessgroung state is not changed across chapter changes. It might take me a while to get to fix it. So marking as draft for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional changes:
The rest are non-functional changes: refactoring, code golf. Anything else is unintentional bugs.
Closes #16648
Closes #13787
Addresses some of #11185.