Apply +-normalization for all email domains #16764
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
migration script added, think this is ready for review |
|
actually, just realized this migration script is wrong because it would undo previous normalizations since it starts from the verbatim email. I guess the right solution is not to create a new script like I did here, but to modify the old script to do all normalization at once. Will fix. |
|
fixed |
|
I don't expect the migration script to run smoothly because db.user4.createIndex({ email: 1 }, { unique: true, sparse: 1 });and removing the |
|
should we just try/catch the update and ignore the rejected duplicates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR because this only changes the code part and does not include anything for database migrations, because I'm not sure what's the best way to write that and how to deal with potential collisions caused by them.
Zulip context topic
Prior to this commit,
+- and.-normalization are only applied to Gmail/ProtonMail. However, using the+for aliasing is done by many more email providers. This commit therefore applies+-normalization to all email domains - I don't think there's any risk in doing that. Removing the dots, however, is still only done for Gmail and ProtonMail because there are email providers (I'm thinking of Outlook here, and there might be others) where dots can absolutely not be ignored.