-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Piece adjustments #16805
Piece adjustments #16805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, if it stays (I think it can) I'd recommend moving the python script to bin/gen and make it executable like licon.py.
It looks like there's some functionality overlap with Maybe that's ok as long as they don't conflict. Just making you aware. |
@fitztrev Oh true, hadn't noticed that. Does the ts script just check for them being in sync, or does it go further and overwrite the css using the svgs? |
It overwrites the css too. Then when the action workflow runs it, it checks the output to make sure there's no difference to what's committed (it verifies they're in sync that way). |
Positioning adjustments for some of the pieces in
pirouetti
,chess7
, andstaunty
. I made a python script to do the adjustments automatically, and have included it in the PR. If not wanted though I'll remove it.