Don't obscure notation when refreshing on a phone #16820
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bscured when refreshing a game on a phone.
|
John, unrelated to this PR but not sure how else to contact you. Do you mind signing up for https://discord.gg/lichess and then DM thibault, or just post something in #general-programming? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a minor issue I've had when playing lichess on my phone in the past, although oddly today I couldn't reproduce it on lichess.org. On gitpod I could though; below are three screenshots that I can get when refreshing the page:
The first one is expected behaviour, while the second slightly cuts off the current move, and the third cuts off way more. Which of these outcomes happens seems to be random, although the third is more rare.
This PR makes it so that the first screenshot is always the final result. If it's initially not, the second
autoScrollcall a tenth of a second later will shift the notation slightly more to the left.