Combine unknown attrs annotate and attr type attrs #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace patch `0027-unknown-attrs-as-annotations.patch` with a new patch that also adds the method `AttributedType::getAttr()` to get the type that an `AttributedType` instance is attributed with. - Update `ports/llvm-16/portfile.cmake` to reflect this change.
|
|
ekilmer
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Nit: Next time, be sure to update the port-version field, like we do in LLVM 15
cxx-common/ports/llvm-15/vcpkg.json
Line 4 in 8b4c12e
This helps people upgrade their current installation more easily without manually removing LLVM-16 and rebuilding.
Ah I remember you telling me that. I will write that down for future reference. |
xlauko
pushed a commit
that referenced
this pull request
Sep 15, 2023
- Replace patch `0027-unknown-attrs-as-annotations.patch` with a new patch that also adds the method `AttributedType::getAttr()` to get the type that an `AttributedType` instance is attributed with. - Update `ports/llvm-16/portfile.cmake` to reflect this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0027-unknown-attrs-as-annotations.patchwith a new patch that also adds the methodAttributedType::getAttr()to get the type that anAttributedTypeinstance is attributed with.ports/llvm-16/portfile.cmaketo reflect this change.