Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up diff generation #271

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Speed up diff generation #271

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47f41ac
Speed up diff generation
frabert May 25, 2022
69e52ac
Use suggestion
frabert Jul 14, 2022
945145e
Do simple checkout
frabert Jul 17, 2022
693305c
Use commit SHA instead of ref
frabert Jul 18, 2022
0316108
Fetch before checkout
frabert Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions .github/workflows/diff_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,11 @@ jobs:
- name: Adding github workspace as safe directory
# See issue https://github.com/actions/checkout/issues/760
run: git config --global --add safe.directory $GITHUB_WORKSPACE
- name: Fetch merge
- name: Checkout base branch
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.base.ref }}
submodules: true
- name: Fetch base branch
uses: actions/checkout@v3
with:
ref: ${{ github.base_ref }}
fetch-depth: 0
submodules: true
path: old
- name: Install utility tools
shell: bash
run: |
Expand All @@ -58,25 +51,36 @@ jobs:
-L -o vcpkg_${{ matrix.image.name }}-${{ matrix.image.tag }}_llvm-${{ matrix.llvm }}_amd64.tar.xz
tar xf vcpkg_${{ matrix.image.name }}-${{ matrix.image.tag }}_llvm-${{ matrix.llvm }}_amd64.tar.xz

- name: Build old rellic
- name: Configure rellic
shell: bash
run: |
cmake -S old -B rellic-build-old -DVCPKG_ROOT=$GITHUB_WORKSPACE/vcpkg_${{ matrix.image.name }}-${{ matrix.image.tag }}_llvm-${{ matrix.llvm }}_amd64
cmake --build rellic-build-old
cmake -S $GITHUB_WORKSPACE \
-B rellic-build \
-DVCPKG_ROOT=$GITHUB_WORKSPACE/vcpkg_${{ matrix.image.name }}-${{ matrix.image.tag }}_llvm-${{ matrix.llvm }}_amd64

- name: Build new rellic
- name: Build old rellic
shell: bash
run: |
cmake -S . -B rellic-build -DVCPKG_ROOT=$GITHUB_WORKSPACE/vcpkg_${{ matrix.image.name }}-${{ matrix.image.tag }}_llvm-${{ matrix.llvm }}_amd64
cmake --build rellic-build
cp rellic-build/tools/rellic-decomp rellic-build/tools/rellic-decomp-old

- name: Checkout merge branch
shell: bash
run: |
git fetch
git checkout ${{ github.event.pull_request.head.sha }}

- name: Build new rellic
shell: bash
run: cmake --build rellic-build

- name: Print job summary
shell: bash
run: |
echo "# Test diffs" >> $GITHUB_STEP_SUMMARY
cd $GITHUB_WORKSPACE/tests/tools/decomp
env CLANG=clang-14 \
OLD_RELLIC=$GITHUB_WORKSPACE/rellic-build-old/tools/rellic-decomp \
OLD_RELLIC=$GITHUB_WORKSPACE/rellic-build/tools/rellic-decomp-old \
NEW_RELLIC=$GITHUB_WORKSPACE/rellic-build/tools/rellic-decomp \
make -s -j1 -f diff_outputs.mk >> $GITHUB_STEP_SUMMARY

Expand All @@ -86,7 +90,7 @@ jobs:
run: |
cd $GITHUB_WORKSPACE/tests/tools/decomp
env CLANG=clang-14 \
OLD_RELLIC=$GITHUB_WORKSPACE/rellic-build-old/tools/rellic-decomp \
OLD_RELLIC=$GITHUB_WORKSPACE/rellic-build/tools/rellic-decomp-old \
NEW_RELLIC=$GITHUB_WORKSPACE/rellic-build/tools/rellic-decomp \
make -s -j1 -f diff_outputs.mk >> $GITHUB_WORKSPACE/test-diff.md

Expand Down